Add torch brightness level support for Android 13+ #174
Conversation
|
nice, lets use the brighest option as default though, not the darkest |
|
Hi @tibbi. This is fixed now from the commit |
|
everytime I turn the flashlight on now, it blinks with max brightness first, then goes to the real selected brightness. It is the easiest to see with some really low setting. Lets make it to the low brightness from the beginning, do not blink with max brightness first. |
app/src/main/kotlin/com/simplemobiletools/flashlight/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -14,7 +15,7 @@ import com.simplemobiletools.flashlight.extensions.updateWidgets | |||
| import com.simplemobiletools.flashlight.models.Events | |||
| import org.greenrobot.eventbus.EventBus | |||
|
|
|||
| class MyCameraImpl(val context: Context) { | |||
| class MyCameraImpl private constructor(val context: Context, private val cameraTorchListener: CameraTorchListener?) { | |||
There was a problem hiding this comment.
Hi @tibbi. Just a suggestion.
The implementation in this class is a bit confusing because we have two implementations for Nougat+ and PreNougat devices. Would it be worth it to refactor this class to share the same API on both implementations (create a common Interface for both) ?
There was a problem hiding this comment.
if it works as it is, lets leave it for now
There was a problem hiding this comment.
Hi,
I had to separate the implementations into different files LollipopFlash and MashmallowPlusFlash for simplicity. It became hard to manage states without having a centralized place.
|
it still blinks at full power at turning on first, then it resets to the proper value. It is the easiest to see by setting the brightness to the lowest |
|
If I turn on the flashlight, exit the app with Back button and start it up again, the brightness seekbar wont show up even if I turn on the flashlight repeatedly |
- fix issues with brightness control - add separate classes for Android 5 and Android 6+ for simplicity - properly cleanup camera in onDestory and also when stroboscope/flashlight mode are disabled
|
Hi @tibbi . |
| import android.graphics.SurfaceTexture | ||
| import android.hardware.Camera | ||
|
|
||
| class LollipopCameraFlash : CameraFlash { |
There was a problem hiding this comment.
I couldn't test this on Android 5. I ensured that it is consistent with what was on the MyCameraImpl class
app/src/main/kotlin/com/simplemobiletools/flashlight/helpers/MyCameraImpl.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/simplemobiletools/flashlight/helpers/MyCameraImpl.kt
Show resolved
Hide resolved
|
I can make both seekbars show up at once, like this. 1. turn on morse code, 2. exit app wth back button, 3. launch app with its icon, 4. turn on flashlight, 5. turn on morse code. Both seekbars will show up. If I then turn off morse code, I have the flashlight icon disabled too, but the brightness seekbar is visible.
|
|
Hi, I fixed this now |
|
I can still reproduce it the same way |
- this prevents the two sliders for brightness and stroboscope from showing up at the same time
KryptKode
force-pushed
the
feat/brightness-control
branch
from
38249bf
to
c975ab1
Compare
| @@ -49,7 +49,6 @@ class MyCameraImpl private constructor(val context: Context, private var cameraT | |||
|
|
|||
| fun toggleStroboscope(): Boolean { | |||
| handleCameraSetup() | |||
| cameraFlash!!.unregisterListeners() | |||
There was a problem hiding this comment.
Apologies, the reason why the issue where the two sliders were showing did not appear fixed is because this listener call was left in the previous push. While reviewing the code before committing, I must have undone the change.
There was a problem hiding this comment.
We needed to move unregistering the listeners after disabling the flashlight so that it can callback on the UI to hide the brightness slider
|
alright, seems to work just fine now, thanks |
Notes
TorchBrightness.mp4