Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing web link to app corrupts target note #311

Closed
Danoloan10 opened this issue Dec 1, 2019 · 15 comments
Closed

Sharing web link to app corrupts target note #311

Danoloan10 opened this issue Dec 1, 2019 · 15 comments
Labels

Comments

@Danoloan10
Copy link

When sharing a web link through Simple-Notes, the target note gets corrupted and opening it crashes the application. The application crashes even when the note shows in the tabs upper row, not even needed to open it. Because of this, I cannot delete the corrupted notes, as to delete them I would have to open them first; and cannot open the notes next to the corrupted.

@tibbi
Copy link
Member

tibbi commented Dec 1, 2019

What app version are you using? I mean what number is at the bottom of the About section.

@Danoloan10
Copy link
Author

version 6.2.1

@tibbi
Copy link
Member

tibbi commented Dec 1, 2019

how exactly could I reproduce it?

@Danoloan10
Copy link
Author

Danoloan10 commented Dec 1, 2019

open a browser or some app that shares links through the share android utility and share the link to Notes. I have had this problem sharing videos with NewPipe and web pages with Lightning to the Notes app

@tibbi tibbi added the bug label Dec 2, 2019
@Danoloan10
Copy link
Author

thanks for the effort. meanwhile, is there any way i can remove these corrupted notes from outside the app, so I can continue using the app normally

@tibbi
Copy link
Member

tibbi commented Dec 3, 2019

I dont think there is. You can create note widgets and see your current notes there to avoid losing them, then reinstall the app I guess. Or just wait for the next version, not sure when will it be released though.

@tibbi
Copy link
Member

tibbi commented Dec 7, 2019

I cannot reproduce it. Havent you tried sharing a video itself in the note, and it crashes just because of the size? Do you have "Make links and emails clickable" enabled in the app settings?

@Danoloan10
Copy link
Author

Danoloan10 commented Dec 7, 2019

ok, now I can't reproduce it either, but the app keeps crashing when the note I made this issue for appears on the screen, even when its just the title in the top bar. Could it be something related to the title? The note is called "r"

edit: the app crashes when trying to create a widget with that note too

@tibbi
Copy link
Member

tibbi commented Dec 7, 2019

What is in the note? Couldnt it be too big?

@Danoloan10
Copy link
Author

it was a new note that i created to copy the link I shared through NewPipe, so I can't know what's in the note

@tibbi
Copy link
Member

tibbi commented Dec 8, 2019

I still cant reproduce it, nor I see a reason why would it be crashing. Sharing via NewPipe works just fine. Try clearing your app data from the device settings, just to see you reset everything (it will clear your notes too). Do you have the "Make links and emails clickable" setting enabled?

@Danoloan10
Copy link
Author

I could export all the notes to .txt. I can see the note with which the app crashes, and it has the youtube link. the file of the name is fine too. however the app kept crashing as before. After importing all notes again to a clean install, it correctly shows the problematic note. No clue what could have happened.

As a side note, checking this I have seen that the .txt files do not include a newline character at the end. It may be a good idea to include it to ease the command line inspection of the files.

@tibbi
Copy link
Member

tibbi commented Feb 25, 2020

does the crash happen to any link, or it contains some special characters? Could you give us the .txt file with the crashing note? If we can reproduce it, we can fix it too. Thanks

@Danoloan10
Copy link
Author

r.txt

This is it. As of today, I have not had the same problem again.

@tibbi
Copy link
Member

tibbi commented Mar 15, 2020

ok thanks, it should be fixed already indeed.

@tibbi tibbi closed this as completed Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants