Group/Folder name, Step Description/Chartname functionality #100
Conversation
"Yo dude, what pack is this song from?" Basically the question everyone asks whenever scores are posted. You can choose between song folder and group on ScreenSelectMusic, but not on ScreenEvaluation. The default is to show the song group; although that option is configurable and found in the Operator Menu under Simply Love Options (below Rainbow mode). -ScreenEvaluation will only display group name because I don't think it's important to have redundant information (since the song folder will almost always have the name of the song in it, which is displayed directly below the group information). If there was an interest, it's super easy to make this configurable in Simply Love options. -Folder displays the full folder name of the song selected. Example: "Eurobeat Is Fantastic/Deja Vu - [Arvin]" Both the name of the pack folder, and the folder the song is found in are listed. This is great for looking for specific songfiles, and especially since song folder names usually have "useful" unformation in them. -Group displays only the pack that the selected song is in. This is good for arcade owners that are concerned about potential "questionable language" in a songfolder name. I'm pretty sure arcade owners know already not to put questionable content in their pack folder names. This is also very useful if you're sorting the songwheel by anything other than group.
This is something that I've been wanting to get out for a very long time. I've finally gotten myself some polished code. Since Stepmania 5, there have been three metadata entries you can use per difficulty, description and chart name. Song descriptions should have information about the current song (stream breakdowns, footswitches, crossovers, literal gay, etc.). Chart name should be used subjectively, perhaps to further help the player understand what a particular difficulty entails. I personally use chart names for things like "Hardest, ECFA version, etc". Chartname, if you didn't notice, also will show up in song options, replacing "Edit" in the difficulty list. This commit also adds these enhancements to ScreenEvaluation. I look forward to stepartists releasing charts utilizing an .ssc file description tag and credit tags properly. As an aside, you can bundle .ssc files next to .sm files and Stepmania 5 will read from the .ssc file rather than the .sm file. (This makes releasing 3.95-compatible content trivial)
Regarding GitGit is complicated and takes a while to learn. I'm glad to hear you spent some time with it yesterday. 👍 It seems you are still committing directly to your master branch, however, so you may want to read about the git branch command for the future. Regarding Lambda/other ThemesI'm very glad to hear you've started to look into Lambda. As I've already written:
You should consider reaching out to @ListenerJubatus if you haven't already. Regarding StepMania ThemingI understand your impatience to "get the ball rolling on a few Stepmania chart features I want to go public" but please try to remember that StepMania theming is a slow process. I worked on SL's initial release version for eighteen months in a vacuum. If you are not prepared to spend hundreds of hours in the company of only your computer, you should probably consider other hobbies. Regarding This Pull RequestThe commits in this pull request are considerably more compact and neat than yesterday's. That's a great start. 👍 Your summary text (above) is still not particularly helpful, and I ultimately found it easier to add your repository as remote, create a local branch for your remote master branch, and try to find the new features in StepMania rather than reading through changes spread across 16 files. It's not that this pull request is too broad in scope (like before), but I could not readily discern what the changes were by reading your above summary. Screenshots often go a long way, and GitHub makes it pretty easy to add them to pull requests like these. Regarding The FeaturesFrom what I can discern, this pull request:
I personally do not like how the two new Quads in SSM and Eval change the aesthetic of those screens. I also do not see these features as a useful or helpful addition to the theme, but I also felt that way about the judgment scatterplot, about the judgment histogram, about highscore lists on ScreenEval, about letter grades in the MusicWheel, about the pacemaker, etc. For better or worse, other people seem to have just eaten those up, and summed, all those features added over time are probably how I've created the current monster that is Simply Love for SM5. I have to wonder how and when it will end. I don't see how it will unless I stop it. I am not interested in merging this pull request at this time. |
|
would you consider pulling the step description enhancements by itself? |
|
What if I resized the Eval banner a small amount to give it more whitespace? |
|
After merging this with my own fork and mucking around a bit with the proposed changes, I have to admit that I see very little (functionally zero) draw back from these changes. They add very useful information as i OFTEN see people asking about a songs origin after someone posts a screenshot. With regard to the added "Theme" option on the main screen, this serves quite a bit less of a purpose, but for a home player it has it's usefulness. Unfortunately, Simply Love is overwhelmingly targeted at Arcade/Dedicab users, and this change (as Dan would say) "not be appropriate" |
That's on my Home Branch, and its changes would not (should not unless I'm misunderstanding git's branches functionality?) be anywhere in this pull request.
|
|
Wasn't even thinking about home mode. Yeah, this is an auto merge imho.
Where is you clock commit?
…On Feb 25, 2018 11:15 PM, "Horsey" ***@***.***> wrote:
added "Theme" option
That's on my Home Branch, and its changes would not (should not unless I'm
misunderstanding git's branches functionality?) be anywhere in this pull
request.
Although added a themes option to the title screen doesn't affect anyone
unless the theme is put into home mode, so I don't see what harm it does.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEwyE18t7uq8v6LAmyodH11C2gukqsL-ks5tYi_ZgaJpZM4SR0V6>
.
|
|
The bottom bar clock begs many questions to be asked. I'm about to commit it to my Event-Mode-Clock branch. Relevant questions here are as follows: -Do we want the clock in 12 hour or 24 hour format? I personally use 24 hour time
-Do we want want to have a different clock format for the Evaluation Screen? I say that the bottom bar clock looks bad on Evaluation. I'd personally use the Wendy font on that screen only instead (remember, in this theme, Evaluation is one of the few screens that don't have the bottom white bar on it, so the aesthetics will be different). I'd also prefer to only have the date, not the clock on the evaluation screen. All that said, I'm finishing up the commit, and will have it live before I go to bed. |
|
I don't have the screens to look at while I am at work, but certainly I
would hope that support for both 12hour and 24hour clocks would be added.
Date could be a configurable option as well, if it isn't too much work.
I don't feel that any theme additions alone be forced until user
desire/acceptability is determined.
…On Feb 26, 2018 12:47 AM, "Horsey" ***@***.***> wrote:
The bottom bar clock begs many questions to be asked. I'm about to commit
it to my Event-Mode-Clock branch.
Relevant questions here are as follows:
-Do we want the clock in 12 hour or 24 hour format? I personally use 24
hour time
-Do we want the date, if so how do we format it? I personally do, but I
can see why others wouldn't
-Do we want the clock in Miso Font (to match the USB/Local profile text)?
I'd say miso if we include the date, and Wendy if not
-Which screens do we want the clock to appear on? I personally say that it
should appear on these:
ScreenSelectMusic, ScreenTitleMenu, ScreenSelectColor, ScreenSelectStyle ,
ScreenSelectPlayMode, ScreenSelectPlayMode2, ScreenPlayerOptions,
ScreenPlayerOptions2, ScreenEvaluationStage
-Do we want want to have a different clock format for the Evaluation
Screen? I say that the bottom bar clock looks bad on Evaluation. I'd
personally use the Wendy font on that screen only instead (remember, in
this theme, Evaluation is one of the few screens that don't have the bottom
white bar on it, so the aesthetics will be different)
All that said, I'm finishing up the commit, and will have it live before I
go to bed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEwyE3NekLlZAJlj8mDKiwQbszCCUJCrks5tYkVxgaJpZM4SR0V6>
.
|
|
clock localization is probably a bit advanced for this theme, but I'll explore a date/time preference screen if Dan is willing to commit this and the clock pull request |
|
Clock localization? Wouldn't your just pull from system time. That would be
the simplest solution
…On Feb 26, 2018 10:32 AM, "Horsey" ***@***.***> wrote:
clock localization is probably a bit advanced for this theme, but I'll
explore a date/time preference screen if Dan is willing to commit this and
the clock pull request
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEwyE4inBENqnmulOfH96CxRCki2SpLhks5tYs5vgaJpZM4SR0V6>
.
|
|
we should probably continue this conversation in the comments of that commit to not be too off topic for this here |
update repo with latest dguzek
|
Doug, I committed this clock functionality to my fork here ("Home" branch): Horsey-/-OLD-Simply-Love-SM5@b302cf9 |
Dan, I've just plainly started from scratch so that I don't have to worry about any messy commits. I've learned a lot about Git today, and I think I understand better how it works. Hopefully this pull request is easier for you to review.
I have already started looking into Lambda, but in the meantime, I wanted to push a few things here so that we can get the ball rolling on a few Stepmania chart features I want to go public. Everyone uses your Simply Love theme at the moment, and really want there to be a way for people to explore the new steps metadata in SM5 (Description/Chartname). My work for the r21 dropbox has been exhausting cleaning up bad use of the credit metadata mucked up with step density. Hopefully this will move stepartists to credit themselves while not feeling constrained. My hopes are that in the future, especially Lambda, that I will add a "sort by stepartst", whereby that requires that stepartists stop filling the credit metadata with things other than their stepartist name. I'd like to get a few more things out to your master, but if I were to ask nothing more of you, these two commits would be it. Hope you have a good rest of your weekend =]