Fix XMod + rate mod when switch X/C/M #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, switching to C/M Mod would convert the XMod but not any existing rate mod. This patch fixes that.
|
Tested on my local branch. Nice patch!! |
|
Thanks for this. I haven't tested this (and don't intend to, as I no longer play StepMania/haven't had access to a machine in nearly a year), but I trust you at this point. Like #102, I am merging this on the notion that it is a bug fix and not a new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, switching to C/M Mod would convert the XMod but not any existing rate mod.
This patch fixes that.