New functionality, second pass #132
Conversation
"Yo dude, what pack is this song from?" Basically the question everyone asks whenever scores are posted. You can choose between song folder and group on ScreenSelectMusic, but not on ScreenEvaluation. The default is to show the song group; although that option is configurable and found in the Operator Menu under Simply Love Options (below Rainbow mode). -ScreenEvaluation will only display group name because I don't think it's important to have redundant information (since the song folder will almost always have the name of the song in it, which is displayed directly below the group information). If there was an interest, it's super easy to make this configurable in Simply Love options. -Folder displays the full folder name of the song selected. Example: "Eurobeat Is Fantastic/Deja Vu - [Arvin]" Both the name of the pack folder, and the folder the song is found in are listed. This is great for looking for specific songfiles, and especially since song folder names usually have "useful" unformation in them. -Group displays only the pack that the selected song is in. This is good for arcade owners that are concerned about potential "questionable language" in a songfolder name. I'm pretty sure arcade owners know already not to put questionable content in their pack folder names. This is also very useful if you're sorting the songwheel by anything other than group.
…a marquee animation This is something that I've been wanting to get out for a very long time. I've finally gotten myself some polished code. Since Stepmania 5, there have been three metadata entries you can use per difficulty, description and chart name. Song descriptions should have information about the current song (stream breakdowns, footswitches, crossovers, literal gay, etc.). Chart name should be used subjectively, perhaps to further help the player understand what a particular difficulty entails. I personally use chart names for things like "Hardest, ECFA version, etc". Chartname, if you didn't notice, also will show up in song options, replacing "Edit" in the difficulty list. This commit also adds these enhancements to ScreenEvaluation. I look forward to stepartists releasing charts utilizing an .ssc file description tag and credit tags properly. As an aside, you can bundle .ssc files next to .sm files and Stepmania 5 will ALWAYS read from the .ssc file rather than the .sm file. (This makes releasing 3.95-compatible content alongside 5.1 content trivial) -As a small aside: I've also made a quick pass on the stepartist bubble animation to be the same as the 3.95 simply love animation, added maxwidth that makes sense (there was none set on the Eval screen).
|
After going through everything with a fine toothed comb, I just realized that I forgot to adjust the y-position of the song rate overlay. I'll get that integer tomorrow, I need sleep lol. |
|
hi, while at it, can we have BPM and Song Length displayed in results screen? :) I would be cool enough with emoticonized variants of those ;P |
|
I'll try to respond to this more fully in the future, but I really think SM5 and the post-ITG community need a new theme that isn't Simply Love. |
|
I appreciate that you took the time to clean this up and resubmit it. I especially appreciate how helpful and fleshed out your pull request description is. The gifs go a long way in quickly and effectively illustrating what changes you've made. I am okay with the idea of marquee-ing through chart Credit, Description, and Chartname. I'd want to spend a little time thinking how I'd want to handle the code for it, and will probably end up not using the code in this pull request. (A new theme should really be designed and implemented.) I don't understand how displaying the filesystem folder of the current song in ScreenSelectMusic is helpful to anyone, but it clearly must be helpful to you or else you wouldn't have bothered to implement it. How does it help you? (A new theme should be designed and implemented.) I like the intent of stepartistbubble.png but not its aesthetic. The triangle being pushed to the edge looks strange to my eye given what I expect of SL's existing aesthetic. (A new theme should be designed and implemented.) Displaying group name in ScreenEvaluation is helpful, but I really don't like the cramped aesthetic. I'm torn. (A new theme should be designed and implemented.) Simply Love Options is way too crowded already (similar to ScreenPlayerOptions2). I like having all these options, but I don't like the UI clutter, and I don't like how confusing it is for novice players. Novice players (and novice machine operators) should always, always be considered when adding new features. (A new theme should be designed and implemented.)
I wasn't supposed to, but life had other plans for me. |
|
the Song folder concept is helpful to see what pack a song is from, -especially- in screenshots of evaluation, and when sorting music by anything other than group. I've found that many tournament packs take the time to improve sync and steps, so when I'm streaming, people can see which pack I'm playing a chart from. This is also useful because many beginners sort by artist or difficulty rather than by group. I'm glad you're down with the Marquee idea and song folder on evaluation at the very least? The aesthetic of the boxes really irked me because the triangle in the original gave the eye a way to see where the information was coming from, pointing to the difficulty cursor of the player, much like the "counts as two rounds"points to the length. Now that you say it, I'd be happier with it if the triangle was shortened a tad. |
This commit adds a third LifeMeter option, Vertical, styled after the stock ITG2 theme. LifeMeter options now include: • Standard • Surround • Vertical
I always forget about this setting. Oops. I've also removed the code that caused the LifeMeter to change from PlayerColor() to white when the LifeMeter was at full health as some users indicated it was distracting.
Action on Target Missed
"The chills, I have them down my spine."
Nothing spookier than an unexpected pause at the end of your audio file.
|
about the group folder name: if you have 5000 songs on the machine, and use sort a lot, then many identically looking simfiles are there next to each other, which make it impossible to identify the pack they belong to at first sight. the current workflow to recognize the pack would be to identify the song in the sort mode, then exit sort mode to Group Sort, then browse up to the folder name. i use this a lot to identify favorable songs. like, to match the 100 versions of Bloody Tears... not everything is about creating a new theme, although i understand you want to quit and say that in favor of you doing again more work. i just tried to explain the usefulness :) |
"Yo dude, what pack is this song from?" Basically the question everyone asks whenever scores are posted. You can choose between song folder and group on ScreenSelectMusic, but not on ScreenEvaluation. The default is to show the song group; although that option is configurable and found in the Operator Menu under Simply Love Options (below Rainbow mode). -ScreenEvaluation will only display group name because I don't think it's important to have redundant information (since the song folder will almost always have the name of the song in it, which is displayed directly below the group information). If there was an interest, it's super easy to make this configurable in Simply Love options. -Folder displays the full folder name of the song selected. Example: "Eurobeat Is Fantastic/Deja Vu - [Arvin]" Both the name of the pack folder, and the folder the song is found in are listed. This is great for looking for specific songfiles, and especially since song folder names usually have "useful" unformation in them. -Group displays only the pack that the selected song is in. This is good for arcade owners that are concerned about potential "questionable language" in a songfolder name. I'm pretty sure arcade owners know already not to put questionable content in their pack folder names. This is also very useful if you're sorting the songwheel by anything other than group.
…a marquee animation This is something that I've been wanting to get out for a very long time. I've finally gotten myself some polished code. Since Stepmania 5, there have been three metadata entries you can use per difficulty, description and chart name. Song descriptions should have information about the current song (stream breakdowns, footswitches, crossovers, literal gay, etc.). Chart name should be used subjectively, perhaps to further help the player understand what a particular difficulty entails. I personally use chart names for things like "Hardest, ECFA version, etc". Chartname, if you didn't notice, also will show up in song options, replacing "Edit" in the difficulty list. This commit also adds these enhancements to ScreenEvaluation. I look forward to stepartists releasing charts utilizing an .ssc file description tag and credit tags properly. As an aside, you can bundle .ssc files next to .sm files and Stepmania 5 will ALWAYS read from the .ssc file rather than the .sm file. (This makes releasing 3.95-compatible content alongside 5.1 content trivial) -As a small aside: I've also made a quick pass on the stepartist bubble animation to be the same as the 3.95 simply love animation, added maxwidth that makes sense (there was none set on the Eval screen).
…-Love-SM5 into New-Functionality
ooppppppsssss I only did this so I can easily select from the master simply love on my machine
|
Does the Marquee effect take place anywhere other than ScreenSelectMusic and ScreenEvaluation? I've re-implemented the functionality and want to ensure I'm covering all the bases. |
|
this only implemented the marquee on ScreenSelectMusic and Evaluation common |
|
Thank you for your effort with this pull request, your diligence in cleaning it up and resubmitting it, your dedication to the community, and your overall enthusiasm for dance games. I am going to close it at this time as I believe it has been effectively supplanted by bbf6e6c. |
Hi Dan, I saw you were releasing new versions of the theme. I wanted to try again submitting a pull request for Stepartist metadata and Group/Folder display on ScreenSelectMusic and ScreenEvaluation common.
-The marquee works such that if no Description or ChartName tag is found, the Credit tag is shown instead. If there is no Credit tag, the current behaviour is unchanged
-The Credit/Description/ChartName texts preserve the most recent update to the theme whereby emojis are not diffused black (not shown below).
This file is live -like many others- on the r21 Dropbox. I have been fixing Credit metadata in all released r21/SM5 content since roughly 2016, and have gone back in time somewhat for files released before then.
This is just showing the three different possibilities for what can be displayed.
This is the Evaluation screen.
Another view of the evaluation Screen. (yo dude, what pack is that from? oh sick I'll go download it!)
This is an example of "Group" being shown in the SongDescription, configurable in Simply Love Options
The quad for SongDescription resizes in Course Mode to retain the current look. The folder/group text is blank on this screen.
Course Mode's Evaluation screen is also similarly unchanged.
