Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenOptionsService: Add ClearCredits option #142

Merged
merged 1 commit into from
Dec 18, 2018
Merged

ScreenOptionsService: Add ClearCredits option #142

merged 1 commit into from
Dec 18, 2018

Conversation

concubidated
Copy link
Contributor

This would be quite helpful for those of us who run this on locations.

@quietly-turning
Copy link
Contributor

Out of genuine curiosity, in what sort of circumstances would you want to clear the credits from a public machine?

@ianklatzco
Copy link
Contributor

We periodically have an issue where we'll take the machine out of event/home mode and back into pay mode, and then we have to clear the credits.

We typically solve this by killing & restarting Stepmania.

@quietly-turning
Copy link
Contributor

Hmm, I'm not sure I understand the usefulness of this option, and I'm generally very reluctant to add more rows to any of the menus. Maybe I'll merge it later today but hide the row when SM5 is not in CoinMode_Pay. Would that be okay, @concubidated?

@concubidated
Copy link
Contributor Author

I added the persistent coins feature awhile back in SM which was helpful for if power goes out, or machine crashes, so people don't lose their credits. This is how most modern games handle it as well.

Sometimes kids swipe in a bunch of credits and walk away, we once had an issue where device enumeration came up backwards and start turned into insert coin, sometimes I will load in credits for testing, then its a pain to clear them out. ITG had this feature as well.

Having it only in pay mode would be awesome! Didn't even think about that.

@quietly-turning
Copy link
Contributor

we once had an issue where device enumeration came up backwards and start turned into insert coin

What a bug! 🙂

Thanks for the persistent coins feature; it's immensely appreciated at the public machine I help maintain.

I'll merge this later today (hopefully) and add some logic to hide the line when not in CoinMode_Pay.

@quietly-turning
Copy link
Contributor

Apologies for sitting on this as long as I have; my attention became tied up in releasing my visual novel for SM5.

I'll try to merge this later today and add the changes I proposed.

@quietly-turning quietly-turning merged commit 6cedcae into Simply-Love:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants