Fix scatter plot bug #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because CurrentSecond includes the offset of whenever the player hit the note, so if you hit the last note(s) super late or the first note(s) super early it will be outside the ends of the song and fall off the graph. But for some reason even after applying this, it STILL falls off the right end (and only the right end). So now there's padding. Maybe the JudgementMessage command takes a few frames to propagate? or GameState precision isn't the best?
|
Eyeballing these changes, I think they seem reasonable. I'll merge it now and we can fine-tune more later if needed. Also, I offer my condolences to your ears. |
|
Also also, good catch on
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (sort of) #77.
The previous code seemed fine other than the offset thing, so I think the Judgment broadcast is not always as timely as it should be. This is supported by the fact that on the song that was reported, the miss bars are not always in the same places across plays.
Also, I've now heard Windows XP Critical Stop more times in the last hour than I have in the preceding few years.