Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE not included in PyPI sdist #7

Closed
jayvdb opened this issue Dec 5, 2020 · 4 comments
Closed

LICENSE not included in PyPI sdist #7

jayvdb opened this issue Dec 5, 2020 · 4 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Dec 5, 2020

The PyPI artifacts needs to include the LICENSE. Recent setuptools will include this automatically.
Otherwise a MANIFEST.in is needed.
@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 5, 2020

btw, https://build.opensuse.org/package/show/home:jayvdb:py-new/python-yamlize created

@SimplyKnownAsG
Copy link
Owner

Sorry, I'm a bit naive on this. Does this mean I just need to update setuptools before building/releasing? I haven't really liked the MANIFEST thing. Any opinions of your own are welcome!

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 8, 2021

You can use a more recent setuptools, and it should do the trick, but IMO explicit (MANIFEST.in) is better than implicit. If using a recent setuptools works for you, add setup_requires=['setuptools>=..'] to avoid regressions.

SimplyKnownAsG added a commit that referenced this issue Oct 9, 2021
@SimplyKnownAsG
Add MANIFEST.in to add LICENSE
58d548b 
issue: GH-7
@SimplyKnownAsG
Copy link
Owner

I think this is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @SimplyKnownAsG