Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backticks around *args in docstring. #13

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

ntouran
Copy link
Contributor

@ntouran ntouran commented Nov 19, 2021

Having parameter docs named *args and **kwargs in a docstring
was causing downstream errors in sphinx where sphinx thought it was
going to be an italic block with a following asterisk or two.

docutils recommends that things like this should be liberals literals:

https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#inline-markup-recognition-rules

Fixes terrapower/armi#481

Having parameter docs named *args and **kwargs in a docstring
was causing downstream errors in sphinx where sphinx thought it was
going to be an italic block with a following asterisk or two.

docutils recommends that things like this should be liberals:

https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#inline-markup-recognition-rules
Copy link
Contributor

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Fixes downstream Sphinx errors in ARMI.

@SimplyKnownAsG
Copy link
Owner

liberals to the rescue :-)

@SimplyKnownAsG SimplyKnownAsG merged commit ee14b14 into SimplyKnownAsG:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants