Don't send empty 'status' and 'type' parameters to API #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When the API is sent an empty status parameter, like "..&status=&", it returns only Active listings. But with not status parameter it returns Active and Pending listings. The plugin was setting empty status parameters on short-code pagintation links when there was no status specified. For example, this would set an empty status parameter: [sr_listings type="Land"] on the pagination links in the output and provide unexpected listings on the next page.
The API does not support an 'area' parameter, it support 'minarea' and 'maxarea', so this documentation is incorrect. See #43
CodyReichert
added
Params & Filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the API is sent an empty status parameter, like "..&status=&", it returns only Active listings. But with not status parameter it returns Active and Pending listings.
The plugin was setting empty status parameters on short-code pagination links when there was no status specified. For example, this would set an empty status parameter:
on the pagination links in the output and provide unexpected listings on the next page.