MS-42 Session Event repository #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhmirin-s
requested review from
a team,
BurningAXE,
alex-vt,
meladRaouf,
TristramN,
ybourgery and
alexandr-simprints
and removed request for
a team
At the same time adds event scope types to the DB model
luhmirin-s
force-pushed
the
feature/MS-42-session-repo
branch
from
d47ec94
to
aad7cbf
Compare
alexandr-simprints
approved these changes
Feb 13, 2024
...main/java/com/simprints/infra/eventsync/event/remote/models/session/ApiEventScopeEndCause.kt
Show resolved
Hide resolved
infra/events/src/main/java/com/simprints/infra/events/event/local/EventDatabaseFactory.kt
Show resolved
Hide resolved
infra/events/src/main/java/com/simprints/infra/events/event/local/EventLocalDataSource.kt
Show resolved
Hide resolved
...ents/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration13to14.kt
Show resolved
Hide resolved
meladRaouf
approved these changes
Feb 13, 2024
...src/test/java/com/simprints/feature/clientapi/usecases/CreateSessionIfRequiredUseCaseTest.kt
Outdated
Show resolved
Hide resolved
luhmirin-s
force-pushed
the
feature/MS-42-session-repo
branch
from
aad7cbf
to
2cf3b77
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation refactoring to clear the event's data structure and DB APIs before introducing a new set of events. Main changes:
sessionIdin events is replaced with a more explicitscopeId. This is because there will be events outside of a session. "Session ID" is now a subset of the more generic "Scope ID".SessionEventRepository.EventRepositoryhave been pruned a bit.This may look like a lot of changes, but it is mostly due to moving some files, new database schema and tests.