Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascii text editing #40

Closed
morningstar1 opened this issue Nov 4, 2016 · 12 comments
Closed

ascii text editing #40

morningstar1 opened this issue Nov 4, 2016 · 12 comments

Comments

@morningstar1
Copy link

It would be nice to be able to edit also the ascii #text in the right area, not only the plain hex values.

@Simsys
Copy link
Owner

Simsys commented Nov 7, 2016

That is a nice idea. Please submit a pull request!

@Simsys Simsys closed this as completed Nov 7, 2016
@morningstar1
Copy link
Author

Give me some time (~one year). I'll give it a try.

@Simsys
Copy link
Owner

Simsys commented Nov 21, 2016

I reopen this enhancement request. Perhaps there is someone providing a pull request

@Simsys Simsys reopened this Nov 21, 2016
@firexx
Copy link

firexx commented Dec 20, 2016

implemented. morningstar1 please test if you have any interest.

@morningstar1
Copy link
Author

Hi Firexx,
thanks for your contribution. Looks good, but there is a issue when you scroll down. The position matting is wrong.

@firexx
Copy link

firexx commented Dec 20, 2016 via email

@firexx
Copy link

firexx commented Dec 22, 2016

morningstar1,

please use the newest changes from my master branch. all known bugs are fixed and shortly be merged in the master branch of the author of this nice widget.

regards
firexx

@morningstar1
Copy link
Author

morningstar1 commented Dec 22, 2016 via email

@Simsys
Copy link
Owner

Simsys commented Dec 22, 2016

I have opened an issue on del key

@firexx
Copy link

firexx commented Dec 22, 2016 via email

@Simsys
Copy link
Owner

Simsys commented Dec 22, 2016

Sebastian, Andrej,

please do not comment on closed issues. This is hard to track. Ongoing discussions should be found in open issues and open pull requests.

There are two possibilities to handle such events

  1. Reopen an issue, if the issue is not finished.
  2. Open a new issue

In this case (DEL key does not work) in my opinion the best way is to open a new issue. This issue does not fit to the original content (Feature request: include ascii editor support)

I already opened a new issue: #60

I really appreciate your engagement in QHexEdit. Thank you very much.

Winfried

@andrej: Please merge my changes before fixing bugs --> 6a61b1a, cf84738

@Simsys
Copy link
Owner

Simsys commented Dec 22, 2016

Sorry this was my fault. This issue was still open.

I close this issue now, because @firexx has realized this feature #51

@Simsys Simsys closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants