feat(openai): support explicit proxy #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mspronesti thanks a lot for the PR, super cool feature! Only a couple of super minor things:
|
|
@gventuri Added some tests and mentioned the proxy in the doc. I also fixed the whole doc of I was surprised to notice that the doc is written manually 😮 . Is there a particular reason ? Why are we not using sphinx ? |
|
@mspronesti I think we are also using sphinx (#94) + some manual things. I guess we should have another discussion about the documentation to make it accessible, well structured but still less painful to write! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gventuri This PR aims at supporting explicit proxy in OpenAI LLMs.