Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while attempting to login using the default API name #109

Closed
marc-aurele-besner opened this issue Jun 5, 2024 · 1 comment
Closed

Error while attempting to login using the default API name #109

marc-aurele-besner opened this issue Jun 5, 2024 · 1 comment

Comments

@marc-aurele-besner
Copy link
Contributor

marc-aurele-besner commented Jun 5, 2024 •
edited
Loading

Error while attempting to login using the default API name error is generated

Trying to login using the default API name, it return an error if the hostname is pretty long

image

The hostname should be trim
@marc-aurele-besner marc-aurele-besner changed the title While attempting to login using the default API name Error while attempting to login using the default API name Jun 5, 2024
@marc-aurele-besner marc-aurele-besner mentioned this issue Jun 5, 2024
Merged
sangaline pushed a commit that referenced this issue Jun 6, 2024
@marc-aurele-besner
Trim hostname to 28 character to avoid too long suggestion for API key (
78e6563 
#110)

Trim hostname to 28 character to avoid login error with too long hostname as suggestion for API key

As mention in #109
@sangaline sangaline mentioned this issue Jun 6, 2024
Merged
sangaline added a commit that referenced this issue Jun 6, 2024
@sangaline
Validate API key length
4a4d8d4 
We collect an API key name during `sindri login` and the backend only supports
a maximum length of 32. This PR adds a simple input validator for the field
that displays an "API key name must 32 characters or fewer" error message and
allows the user to modify the input and try again. Previously they would have
gotten a fatal API error requiring them to start over and re-enter their
credentials.

Connects #109

Merges #111
@sangaline
Copy link
Contributor

Thanks for reporting and for submitting your #110 PR! That has been merged now, and I also added client-side length validation in #111. Both changes are available in the latest v0.0.1-alpha.48 release. Please let us know if you run into any additional issues, and thanks again for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sangaline @marc-aurele-besner