Second branch to be reviewed before merge #2
Conversation
| const symbols = await this.geneService.fetchGeneSymbols(); | ||
| return symbols; |
There was a problem hiding this comment.
| const symbols = await this.geneService.fetchGeneSymbols(); | |
| return symbols; | |
| return await this.geneService.fetchGeneSymbols(); |
There was a problem hiding this comment.
made this change and tested that the api and dropdown both still work
apps/api/src/main.ts
Outdated
| @@ -13,7 +13,7 @@ async function bootstrap() { | |||
| const app = await NestFactory.create(AppModule); | |||
| const globalPrefix = 'api'; | |||
| app.setGlobalPrefix(globalPrefix); | |||
| let origin = process.env.CTIMS_ENV === 'development' ? '*' : 'https://ctims.ca'; | |||
| let origin = process.env.CTIMS_ENV === 'development' ? '*' : 'http://localhost:3000'; | |||
There was a problem hiding this comment.
If I leave it in its original form, then the CTIMS home page does not load properly. I'll revert to original form before making the final commit
There was a problem hiding this comment.
CITMS_ENV should come from the .env file. First copy the .env.example file with the CITMS_ENV variable in it to same directory and name it .env. Next set the value to "development" then it should make origin "*" which should make everything work.
| useEffect(() => { | ||
| async function fetchTopSymbols() { | ||
| try { | ||
| const response = await axios.get('http://localhost:3333/api/genes') |
There was a problem hiding this comment.
You could consider using useAxios hook under web/hooks
There was a problem hiding this comment.
would that look like this?
`axios.defaults.baseURL = 'http://localhost:3333/api';
const useAxios = () => {
const [hugoSymbols, setHugoSymbols] = useState([]);
const [error, setError] = useState('');
const fetchHugoSymbols = () => {
axios
.get('/genes')
.then(function (response) {
const symbols = response.data;
setHugoSymbols(symbols);
hugoSymbols.push(symbols);
})
.catch((err) => {
setError(err);
})
};
useEffect(() => {
fetchHugoSymbols();
}, []);
return hugoSymbols;
};`
| @@ -4,7 +4,7 @@ DATABASE_URL=mysql://ctims:ctims@localhost:3306/ctims | |||
| KEYCLOAK_URL=http://localhost:8080 | |||
| KEYCLOAK_CLIENT_ID=ctims | |||
|
|
|||
| # Keycloak client uuid. This is different from the id above. | |||
| # Keycloak client uuid. This is daifferent from the id above. | |||
| KEYCLOAK_URL=<KEYCLOAK_URL> | ||
| KEYCLOAK_CLIENT_ID=<client_id> | ||
| KEYCLOAK_CLIENT_UUID=<uuid> | ||
| KEYCLOAK_REALM=<realm> | ||
| KEYCLOAK_CLIENT_SECRET=<client_secret> | ||
| KEYCLOAK_ADMIN_CLIENT_ID=ctims-admin # a client with sevice account enabled | ||
| KEYCLOAK_ADMIN_CLIENT_SECRET=<secret> |
There was a problem hiding this comment.
I think we should restore to what they have previously.
| try { | ||
| return await this.geneService.fetchGeneSymbols(); | ||
| } catch (error) { | ||
| console.error('Error fetching data:', error); | ||
| } |
There was a problem hiding this comment.
I don't think you should catch the error but rather throw the exception so the frontend is aware.
Hugo gene symbol dropdown added returning top 50 options of the full hugo gene list utilizing gene api