Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature wallet #14

Merged
merged 6 commits into from
May 28, 2022
Merged

Feature wallet #14

merged 6 commits into from
May 28, 2022

Conversation

kozayupapa
Copy link
Collaborator

@kozayupapa kozayupapa commented May 26, 2022

  • metamask との連携機能追加
  • nouns love のアイコンを持っていた場合は地図上に描画
  • nouns のアイコンとIDをstorage, firestoreにup
  • 時間と通信量削減のため、width 600 にresize した写真をUPするように修正

image

image

TODO

  • etherscanのAPIKeyをSecretに移動して今のは削除する
  • lint any に対する対応考える
  • contractor のアドレス nouns love, nouns 本家 切り替え方検討

@kozayupapa kozayupapa changed the title [feature wallet]Feature wallet [WIP]Feature wallet May 26, 2022
@github-actions
Copy link

github-actions bot commented May 26, 2022

Visit the preview URL for this PR (updated for commit 6f18f04):

https://nounsmap-web-dev--pr14-feature-wallet-l76muxdn.web.app

(expires Sat, 04 Jun 2022 03:16:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

src/components/Wallet.vue Outdated Show resolved Hide resolved
src/components/Wallet.vue Outdated Show resolved Hide resolved
src/components/Wallet.vue Outdated Show resolved Hide resolved
src/i18n/en.ts Outdated Show resolved Hide resolved
@kozayupapa kozayupapa changed the title [WIP]Feature wallet Feature wallet May 28, 2022
@kozayupapa
Copy link
Collaborator Author

@isamu 残Issueは #15 #16 #17 で別PRで扱いたいと思います。
こちらいったん nft token のicon Upload までできたので、 確認、マージお願いします。
このあとtwitter 投稿画面OGPへの反映につなげたいとおもいます。

@@ -63,6 +63,13 @@ import { ethers } from "ethers";
const nounsTokenJson = require("./NounsToken9331f10808.json");
// import firebaseApp from '@/src/main.js'

declare global {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/shims-vue.d.ts に、

interface Window { ethereum: any|undefined; };

すると、どのコンポーネントでも使えるようになります(これは別PRで!)

@@ -72,31 +79,27 @@ export default defineComponent({
//const contractAddress = "0xbe41F43c0d2cCbfce561429F18d3473DFa17eBAd"; // desc for actual nouns // for rinkeby
const contractAddress = "0xA409B4d308D6234b1E47b63ae1AEbE4fb5030D2a"; // for rinkeby 0524 version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後で設定ファイルをつくって、そちらに移動させましょう。

@@ -12,7 +12,7 @@ const lang = {
selectPhotoLocation:
"Please move the map so that the location of the photo is in the center.",
spotPrivacyLevel: "SpotPrivacyLevel",
requestAccount: "metamask wallet connect",
requestAccount: "connect MetaMask",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect -> Connect

@@ -10,7 +10,7 @@ const lang = {
processing: "送信中です...",
selectPhotoLocation: "写真の場所が中心になるように地図を移動してください",
spotPrivacyLevel: "場所のプライバシーレベル",
requestAccount: "metamask wallet 接続",
requestAccount: "connect MetaMask",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect -> Connectか、日本語へ。

@isamu
Copy link
Contributor

isamu commented May 28, 2022

ありがとうございます!
いくつかコメントしましたが、別PRで対応をお願いします。

@isamu isamu merged commit a5633d3 into main May 28, 2022
kozayupapa added a commit that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants