This repository has been archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] [PORT] Popper Tooltips 2 (they don't crash this time) #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Popper Tooltips 2 (they don't crash this time) (#58980) Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Fix guardian stats names and tooltips not working * Update KitchenSink.js to match Tooltip.stories.js * Build tgui * Rebuild tgui * Fix CRLF * Expand guardian window Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
KubeRoot
approved these changes
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#4832
About The Pull Request
Ports the following PR:
Tooltips now use Popper, which allows them to work more reliably, including automatically changing the tooltip position if it were to go offscreen.
Visually, the tooltips should be unchanged in most situations, except for cases where they'd go off-screen.
NOTE: In terms of code, tooltip usage has changed. Previously you would put a tooltip element inside the thing that gets the tooltip. Now you wrap the tooltip around the thing that gets the tooltip.
Additionally fixes Guardian.js (holoparasite) stats - they were completely broken, displaying [object Object] instead of the name. Now they display the name and tooltip with descrition properly. Also expand it by 80 pixels (500->580) horizontally so the tabs fit properly, otherwise they get scrunched up and look horrible.
Why It's Good For The Game
Better-behaved tooltips, fixes holoparasite stat selection.
Changelog
馃啈
code: tgui tooltips now use Popper
fix: Holoparasite stat selection now displays stats correctly
/:cl: