Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fax QoL and fixes #958

Closed
wants to merge 2 commits into from
Closed

Conversation

SinguloMirrorbot
Copy link
Collaborator

Original PR: BeeStation/BeeStation-Hornet#9236

About The Pull Request

  • Removes snowflake var-edited mapped fax machines in favor of typepathed fax machines.
  • Gives every fax machine a radio to be able to announce incoming faxes to the department (with cooldown)
  • Aformentioned radio speaks in LOUDMODE when received from important individuals (CC)
  • There is now a CC fax machine that receives the physical paper from CC/IC admin directed faxes
  • Gives Interns and ERTs the ability to send CC faxes.
  • Also makes it so that the fax (and echosniffer I copied the code from) send a chat/visible message regardless of what the radio says
  • Removes the ansible crystal requirement (under tcomms research)

Why It's Good For The Game

I'm not really sure why typepaths weren't included in BeeStation/BeeStation-Hornet#8821, but this adds them now. Interns/Inspectors from CC are probably the FIRST people who should have access to sending messages back via fax, this adds them.

Additionally, from my own testing, with the fax machines taking any more than the basic parts, it is incredibly expensive for no real reason I've found.

Testing Photographs and Procedure

Screenshots&Videos

dreamseeker_N63WsTCnnf

dreamseeker_uhi7kw285L

Changelog

馃啈
add: Fax machines now announce that they have received a fax over department radio
add: Fax machines announce important faxes VERY LOUDLY
fix: CC Interns/Inspectors/ERTs can now send faxes to CC
code: faxes now use typepath instead of varedit
balance: faxes no longer require subspace ansible crystal
/:cl:

mystery3525 and others added 2 commits June 23, 2023 14:37
* code changes

* map changes

* send a visible message regardless of the radio

* unreachable code

* use globs

* shitcode

* this now works

* consistency

* remove subspace crystal requirement
@MaltVinegar MaltVinegar deleted the upstream-merge-9236 branch June 23, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants