Improvements to session stack #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The autorefresh was incomplete : it renewed the session timestamp, protecting it against removal by the PHP session GC, but did not protected stack against removal by ATK GC.
As a consequence, if you waited too long on a page (longer than session_max_stack_inactivity_period, 1h per default), you were not able to come back in the stack and it could lead to data loss in some cases. See this testcase for an example.
This PR fixes that and also removes the "namespace" functionnality of SessionManager, since isolation is already provided by session_name and identifier config values.
More refactoring could be done to clean code in sessionmanager and remove some global variables. Not sure if I will have time to do it soon.