Skip to content

Commit

Permalink
Rename EffectNode::process to transform
Browse files Browse the repository at this point in the history
  • Loading branch information
SirBob01 committed May 17, 2023
1 parent 0b00302 commit 65a555b
Show file tree
Hide file tree
Showing 10 changed files with 38 additions and 34 deletions.
2 changes: 1 addition & 1 deletion src/Sound/EffectNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ namespace Dynamo::Sound {
u32 length,
ListenerSet &listeners) {
// TODO: Implement
return process(src, offset, length, listeners);
return transform(src, offset, length, listeners);
}
} // namespace Dynamo::Sound
8 changes: 5 additions & 3 deletions src/Sound/EffectNode.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,15 @@ namespace Dynamo::Sound {
Sound &run(Sound &src, u32 offset, u32 length, ListenerSet &listeners);

/**
* @brief Process a Sound.
* @brief Transform a Sound.
*
* @param src
* @param length
* @param listeners
*/
virtual Sound &
process(Sound &src, u32 offset, u32 length, ListenerSet &listeners) = 0;
virtual Sound &transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) = 0;
};
} // namespace Dynamo::Sound
8 changes: 4 additions & 4 deletions src/Sound/Filters/Attenuation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ namespace Dynamo::Sound {
return (_cutoff_radius - distance) / (_cutoff_radius - _inner_radius);
}

Sound &Attenuation::process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
Sound &Attenuation::transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
ListenerProperties &listener = listeners.find_closest(position);
f32 distance = (position - listener.position).length();
f32 gain = linear(distance);
Expand Down
8 changes: 4 additions & 4 deletions src/Sound/Filters/Attenuation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ namespace Dynamo::Sound {
*/
Attenuation(f32 inner_radius, f32 cutoff_radius);

Sound &process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
Sound &transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
};
} // namespace Dynamo::Sound
8 changes: 4 additions & 4 deletions src/Sound/Filters/Binaural.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Dynamo::Sound {
_output.set_channels(2);
}

Sound &Binaural::process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
Sound &Binaural::transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
ListenerProperties &listener = listeners.find_closest(position);
_hrtf.get().calculate_HRIR(listener.position,
listener.rotation,
Expand Down
8 changes: 4 additions & 4 deletions src/Sound/Filters/Binaural.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ namespace Dynamo::Sound {
*/
Binaural(HRTF &hrtf);

Sound &process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
Sound &transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
};
} // namespace Dynamo::Sound
6 changes: 4 additions & 2 deletions src/Sound/Filters/Gain.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#include "./Gain.hpp"

namespace Dynamo::Sound {
Sound &
Gain::process(Sound &src, u32 offset, u32 length, ListenerSet &listeners) {
Sound &Gain::transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
_output.resize(length, src.channels());
for (u32 c = 0; c < src.channels(); c++) {
for (u32 f = 0; f < length; f++) {
Expand Down
8 changes: 4 additions & 4 deletions src/Sound/Filters/Gain.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ namespace Dynamo::Sound {
*/
f32 gain = 1.0;

Sound &process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
Sound &transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
};
} // namespace Dynamo::Sound
8 changes: 4 additions & 4 deletions src/Sound/Filters/Stereo.cpp
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#include "./Stereo.hpp"

namespace Dynamo::Sound {
Sound &Stereo::process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
Sound &Stereo::transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) {
ListenerProperties &listener = listeners.find_closest(position);
Vec3 delta = position - listener.position;
Vec3 up = listener.rotation.up();
Expand Down
8 changes: 4 additions & 4 deletions src/Sound/Filters/Stereo.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ namespace Dynamo::Sound {
*/
Vec3 position;

Sound &process(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
Sound &transform(Sound &src,
u32 offset,
u32 length,
ListenerSet &listeners) override;
};
} // namespace Dynamo::Sound

0 comments on commit 65a555b

Please sign in to comment.