Rewrite in Kotlin + Dropping Apache HTTP Client #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirWellington
commented
Jan 23, 2018
pom.xml
Outdated
| </parent> | ||
|
|
||
| <artifactId>alchemy-http</artifactId> | ||
| <version>2.1-SNAPSHOT</version> | ||
| <version>2.1-kotlin</version> |
There was a problem hiding this comment.
Obviously, drop the -kotlin monicker
| @@ -57,8 +58,8 @@ | |||
| <properties> | |||
|
|
|||
| <!--Java Compiler Properties--> | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <maven.compiler.source>1.6</maven.compiler.source> | |||
| * | ||
| * @return | ||
| */ | ||
| static AlchemyHttp newDefaultInstance() |
There was a problem hiding this comment.
yup. Won't be missed.
| */ | ||
| fun go(): AlchemyRequest.Step1 | ||
|
|
||
| companion object |
There was a problem hiding this comment.
Name the companion object Factory, since it better encapsulates what this is for
| { | ||
|
|
||
| /** | ||
| * Creates a new [AlchemyHttp] using the default settings for the [Apache HTTP Client][HttpClient] |
There was a problem hiding this comment.
Update the doc, since the library no longer uses Apache HTTP Client
|
|
||
| /** | ||
| * | ||
| * @author SirWellington |
There was a problem hiding this comment.
Bruh, add some java docs here
|
|
||
| val newParam = Pair(name, value) | ||
|
|
||
| val queryParams = request.queryParams?.plus(newParam) ?: mapOf(newParam) |
There was a problem hiding this comment.
Nice!
You probably don't need the empty line above it.
| override fun toString(): String | ||
| { | ||
| var string = super.toString() | ||
| if (hasResponse()) |
There was a problem hiding this comment.
Probably replace with null-check and Elvis operator
| */ | ||
| @RunWith(AlchemyTestRunner::class) | ||
| @IntegrationTest | ||
| class DomainsDBTest |
There was a problem hiding this comment.
Love these tests. Maybe throw some repetitions in there, like 5
| */ | ||
| @RunWith(AlchemyTestRunner.class) | ||
| @IntegrationTest | ||
| public class WordnikAPITest |
+ Renames HttpExecutor to HttpRequestExecutor
+ Adds documentation notes
+ Adds documentation notes
+ Refines code
+ Refines code
+ Refines code
|
Looks good! Approved. |
|
|
This was referenced Jan 23, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the entire Library in Kotlin, and drops usage of the Apache HTTP Client, in favor of the native
HTTPURLConnectioninterface.This makes the code compatible with the Android platform as well as the native JDK.