Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dia backend #3

Merged
merged 2 commits into from Mar 15, 2023
Merged

feat: add dia backend #3

merged 2 commits into from Mar 15, 2023

Conversation

unger1984
Copy link
Contributor

Added dia library. The tests are encouraging, but there are two problems:

  1. I'm not sure that I did everything right. Parsing json and receiving files is implemented under the hood of dia_body, in test routes I just check that the data has come to me. See if it's done right.
  2. benchmark.sh cannot kill the server process and the following benchmarks cannot start. I checked on MacOS, maybe this is the problem.

@SirusCodes
Copy link
Owner

Added dia library. The tests are encouraging, but there are two problems:

Thanks a lot for contributing

  1. I'm not sure that I did everything right. Parsing json and receiving files is implemented under the hood of dia_body, in test routes I just check that the data has come to me. See if it's done right.

I will check that in a while

  1. benchmark.sh cannot kill the server process and the following benchmarks cannot start. I checked on MacOS, maybe this is the problem.

sh file is broken you can try running the python script or we can just check the results from CI 😅

.gitignore Outdated Show resolved Hide resolved
@SirusCodes
Copy link
Owner

Just a suggestion, you should work a bit more on the documentation for your packages. It was a bit difficult for me to understand the features of it.

Adding examples with what it does would be good enough.

Copy link
Owner

@SirusCodes SirusCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirusCodes SirusCodes merged commit 4217cd7 into SirusCodes:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants