Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon box component: hide fields depending on type #111

Closed
chinthakagodawita opened this issue Jun 8, 2017 · 1 comment
Closed

Icon box component: hide fields depending on type #111

chinthakagodawita opened this issue Jun 8, 2017 · 1 comment
Assignees
@deneus
Labels
enhancement future
Projects
v1.1.0

Comments

@chinthakagodawita
Copy link
Contributor

Changing the icon box type to 'image' or 'icon' should hide or show the 'image' or 'icon' field as required.

Doing this with Javascript might be easier.

Known issue from #107
@gig745 gig745 added this to To Do in v1.1.0 Jun 14, 2017
deneus added a commit that referenced this issue Jun 23, 2017
@deneus
#111: adding files
a47b199
deneus added a commit that referenced this issue Jun 23, 2017
@deneus
#111: create the library
0bd2d60
deneus added a commit that referenced this issue Jun 23, 2017
@deneus
#111: attach the JS to the form
e4a40bf
deneus added a commit that referenced this issue Jun 23, 2017
@deneus
#111: create the behaviour and the function conditional_display
94a1d32
@deneus deneus mentioned this issue Jun 23, 2017
Merged
deneus added a commit that referenced this issue Jun 23, 2017
@deneus
#111: update changelog
edf8a34
deneus added a commit that referenced this issue Jun 23, 2017
@deneus
#111: fixes for codify
9dbe75e
deneus added a commit that referenced this issue Jun 26, 2017
@deneus
#111: update js to be codacy compliant
034e73e
deneus added a commit that referenced this issue Jun 26, 2017
@deneus
#111: update code to make it travis compliant
86174e5
@deneus deneus moved this from To Do to In Progress in v1.1.0 Jun 26, 2017
deneus added a commit that referenced this issue Jun 29, 2017
@deneus
#111: change Jquery by $
ad00fbe
deneus added a commit that referenced this issue Jun 29, 2017
@deneus
#111: move js file into src
4b01386
deneus added a commit that referenced this issue Jun 29, 2017
@deneus
#111: update gulp file to compile JS
97a8567
gig745 pushed a commit that referenced this issue Aug 10, 2017
@deneus
Feature/111 conditional display (#138)
bf2ff79 
* #111: adding files

* #111: create the library

* #111: attach the JS to the form

* #111: create the behaviour and the function conditional_display

* #111: update changelog

* #111: fixes for codify

* #111: update js to be codacy compliant

* #111: update code to make it travis compliant

* #111: change Jquery by $

* #111: move js file into src

* #111: update gulp file to compile JS

* Added module JS compilation.

* Added compiled icon box JS.

* Fixed eslint/ES6 issues.

* Updated yarn.lock.

* Excluded compiled JS from PHPCS checks.

* Fixed PHPCS issues.

* Don't kill pipeline on webpack error.

* Fixed all icon boxes being triggered on type change.
@gig745
Copy link
Contributor

gig745 commented Aug 10, 2017

merged into 1.1

@gig745 gig745 closed this as completed Aug 10, 2017
@gig745 gig745 moved this from In Progress to Done in v1.1.0 Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deneus deneus

Labels
enhancement future
Projects
v1.1.0
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chinthakagodawita @gig745 @deneus