Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColumnHider button is no longer a tab stop #1426

Closed
edhager opened this issue Aug 15, 2018 · 0 comments · Fixed by #1453
Closed

ColumnHider button is no longer a tab stop #1426

edhager opened this issue Aug 15, 2018 · 0 comments · Fixed by #1453

Comments

@edhager
Copy link
Member

edhager commented Aug 15, 2018 •
edited

When I fixed some problems with the column hider button disappearing for #1372 in 4da0f2a but I caused an accessibility problem. The button is no longer a tab stop because I changed it from a <button> to a <div>.
@edhager edhager mentioned this issue Aug 15, 2018
Closed
msssk added a commit to msssk/dgrid that referenced this issue Apr 3, 2020
@msssk
Fix: a11y for ColumnHider button
8c0c3e8 
* set role="button" and tabindex="0" on DOM node
* add keydown handler for enter and space on node to toggle menu

Fixes SitePen#1426
msssk added a commit to msssk/dgrid that referenced this issue Apr 3, 2020
@msssk
Fix: a11y for ColumnHider button
c13e78a 
* set role="button" and tabindex="0" on DOM node
* add keydown handler for enter and space on node to toggle menu

Fixes SitePen#1426
@msssk msssk mentioned this issue Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: a11y for ColumnHider button msssk/dgrid
1 participant
@edhager