Focus and selection broken in Edge and Chrome 55 #1334
Conversation
Pointer events break this.
| @@ -8,6 +8,10 @@ define([ | |||
| './util/misc', | |||
| 'dojo/_base/sniff' | |||
| ], function (declare, aspect, domClass, on, lang, has, miscUtil) { | |||
|
|
|||
| var hasPointer = has("pointer"), | |||
| hasMSPointer = hasPointer && hasPointer.slice(0, 2) === "MS", | |||
There was a problem hiding this comment.
I think it would be more robust to add something like has-pointer.js to https://github.com/SitePen/dgrid/tree/master/util and make these options all be feature tests so they may be excluded from Dojo builds (e.g. if you don't need IE10 pointer event support). Also would probably suggest an upstream fix to dojo/has...
There was a problem hiding this comment.
Dojo 1.10 and newer have an MS pointer event feature test, dojo/dojo@b25b080 , so we could use that. In order to support Dojo versions prior to 1.10, we could replicate that test in a dgrid/util/has-pointer module?
There was a problem hiding this comment.
We also have dojo/dojo@b25b080 ... so again, I think if we properly use has('msPointer') that will work fine for Dojo 1.10+, though we should probably include the same pointer logic for pre-Dojo 1.10 dgrid users...
|
Fixed in #1445 |
Pointer events break this.