Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolrServiceValidator does not check that the related Solr service may not exist #645

Closed
DmitryKolinchuk opened this issue Nov 25, 2021 · 0 comments · Fixed by #646
Closed

SolrServiceValidator does not check that the related Solr service may not exist #645

DmitryKolinchuk opened this issue Nov 25, 2021 · 0 comments · Fixed by #646
Assignees
@DmitryKolinchuk
Labels
bug released
Projects
Main SIM project
Milestone
2021Q4

Comments

@DmitryKolinchuk
Copy link
Collaborator

'SolrServiceValidator' should check that the related Solr service exists before checking if the service is running, because Solr may be running without service.
This is controlled by the 'GetServiceState' method of 'SolrStateResolver'.
@DmitryKolinchuk DmitryKolinchuk added this to the 2021Q4 milestone Nov 25, 2021
@DmitryKolinchuk DmitryKolinchuk self-assigned this Nov 25, 2021
@DmitryKolinchuk DmitryKolinchuk added this to To be triaged in Main SIM project via automation Nov 25, 2021
@DmitryKolinchuk DmitryKolinchuk moved this from To be triaged to In Progress: 2021Q4 in Main SIM project Nov 25, 2021
DmitryKolinchuk added a commit that referenced this issue Nov 25, 2021
@DmitryKolinchuk
#645 Add check that Solr service exist
31b06a3
DmitryKolinchuk added a commit that referenced this issue Nov 25, 2021
@DmitryKolinchuk
#645 Remove unnecessary code from SolrServiceValidatorTests
a5a92ea
@DmitryKolinchuk DmitryKolinchuk linked a pull request Nov 25, 2021 that will close this issue
Feature/645 solr service validator does not check that the related solr service may not exist #646
Merged
DmitryKolinchuk added a commit that referenced this issue Nov 26, 2021
@DmitryKolinchuk
#645 Add Solr service type
e98a507
Main SIM project automation moved this from In Progress: 2021Q4 to Done Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryKolinchuk DmitryKolinchuk

Labels
bug released
Projects
Main SIM project
  
Done
Milestone
2021Q4
2 participants
@DmitryKolinchuk @AndreyFilchenkov