Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB#8808 Sync with xmcloud-foundation-head (JSS 21.2.1) #84

Merged
merged 16 commits into from Jul 10, 2023
Merged

AB#8808 Sync with xmcloud-foundation-head (JSS 21.2.1) #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8d73893
Update package.json
chpa7 Jun 30, 2023
cf64ffb
Update sitecore.json & xmcloud.build.json
chpa7 Jun 30, 2023
af03ff2
Update up.ps1
chpa7 Jun 30, 2023
58a6a16
Add NEXT_PUBLIC_PERSONALIZE_SCOPE environment variable
chpa7 Jun 30, 2023
f189839
Update next.config.js
chpa7 Jun 30, 2023
b9f013d
Update extensions.json in .vscode folder
chpa7 Jun 30, 2023
a6e8c7d
Update everything under scripts folder
chpa7 Jun 30, 2023
8b94d0d
Add install-pre-push-hook script to package.json
chpa7 Jun 30, 2023
a413ab1
Update everything under src folder
chpa7 Jun 30, 2023
995c025
Fix lint errors
chpa7 Jun 30, 2023
91635fb
Update scaffold script path
chpa7 Jun 30, 2023
c3c6c94
Update generate-plugins.ts with missing option
chpa7 Jul 3, 2023
3f39579
Update package-lock.json
chpa7 Jul 3, 2023
e87722c
Extract storybook into its own plugin
chpa7 Jul 4, 2023
9438065
Make 404 page match the one from xmcloud-foundation-head
chpa7 Jul 4, 2023
e7513c3
Add 500 page
chpa7 Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/extensions.json
View file
Open in desktop
Expand Up @@ -10,6 +10,8 @@
"bradlc.vscode-tailwindcss",
"shardulm94.trailing-spaces",
"rbbit.typescript-hero",
"redhat.vscode-yaml"
"redhat.vscode-yaml",
"GraphQL.vscode-graphql",
"mikestead.dotenv"
]
}
2 changes: 1 addition & 1 deletion sitecore.json
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
"Sitecore.DevEx.Extensibility.Publishing@5.1.25",
"Sitecore.DevEx.Extensibility.Indexing@5.1.25",
"Sitecore.DevEx.Extensibility.ResourcePackage@5.1.25",
"Sitecore.DevEx.Extensibility.XMCloud@1.1.16"
"Sitecore.DevEx.Extensibility.XMCloud@1.1.30"
],
"serialization": {
"defaultMaxRelativeItemPathLength": 100,
Expand Down
13 changes: 9 additions & 4 deletions src/rendering/.env
View file
Open in desktop
Expand Up @@ -63,15 +63,20 @@ NEXT_PUBLIC_CDP_TARGET_URL=
# Your Sitecore CDP client key
NEXT_PUBLIC_CDP_CLIENT_KEY=

# An optional Sitecore Personalize scope identifier.
# This can be used to isolate personalization data when multiple XM Cloud Environments share a Personalize tenant.
# This should match the PAGES_PERSONALIZE_SCOPE environment variable for your connected XM Cloud Environment.
NEXT_PUBLIC_PERSONALIZE_SCOPE=

# Your Sitecore CDP point(s) of sale
# Can be provided as a single value (mypoint.com) or a multi-value JSON with locales ({"en":"en.mypoint.com","fr":"fr.mypoint.com"} etc)
NEXT_PUBLIC_CDP_POINTOFSALE=

# Timeout (ms) for Sitecore CDP requests to respond within. Default is 250.
PERSONALIZE_MIDDLEWARE_CDP_TIMEOUT=400
# Timeout (ms) for Sitecore CDP requests to respond within. Default is 400.
PERSONALIZE_MIDDLEWARE_CDP_TIMEOUT=

# Timeout (ms) for Sitecore Experience Edge requests to respond within. Default is 250.
PERSONALIZE_MIDDLEWARE_EDGE_TIMEOUT=400
# Timeout (ms) for Sitecore Experience Edge requests to respond within. Default is 400.
PERSONALIZE_MIDDLEWARE_EDGE_TIMEOUT=

# DEMO TEAM CUSTOMIZATION - Integrations
## Custom CDP/Personalize integration
Expand Down
7 changes: 1 addition & 6 deletions src/rendering/next.config.js
View file
Open in desktop
@@ -1,5 +1,5 @@
const jssConfig = require('./src/temp/config');
const { getPublicUrl } = require('@sitecore-jss/sitecore-jss-nextjs');
const { getPublicUrl } = require('@sitecore-jss/sitecore-jss-nextjs/utils');
const plugins = require('./src/temp/next-config-plugins') || {};

const publicUrl = getPublicUrl();
Expand Down Expand Up @@ -51,11 +51,6 @@ const nextConfig = {
source: '/-/:path*',
destination: `${jssConfig.sitecoreApiHost}/-/:path*`,
},
// visitor identification
{
source: '/layouts/system/:path*',
destination: `${jssConfig.sitecoreApiHost}/layouts/system/:path*`,
},
// healthz check
{
source: '/healthz',
Expand Down