Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/kiosk 91 #46

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Features/kiosk 91 #46

merged 3 commits into from
Jan 14, 2019

Conversation

alexshyba
Copy link

Kiosk app with mobile app refactoring

jeanfrancoislarente
jeanfrancoislarente approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@jeanfrancoislarente jeanfrancoislarente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor question. Otherwise looks good. Need to coordinate pushing to server first?

fitness/app/src/components/EventList/index.js Show resolved Hide resolved
@alexshyba
Copy link
Author

@jeanfrancoislarente you can update the QA server after the fact. In the ideal world we have these two connected, so PR kicks deploys the code to a temporary instance of Sitecore, does build.ps1, then Netlify does it's thing and we run e2e tests... Since we don't have it setup like that, we can do deployment to QA server manually.

@jeanfrancoislarente jeanfrancoislarente merged commit 641af1c into master Jan 14, 2019
@jeanfrancoislarente jeanfrancoislarente deleted the features/kiosk-91 branch January 14, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanfrancoislarente jeanfrancoislarente jeanfrancoislarente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexshyba @jeanfrancoislarente