Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Move away from rxjs use for lazyloading in favor of more direct approach #1307

Merged
merged 1 commit into from Jan 27, 2023
Merged

[Angular] Move away from rxjs use for lazyloading in favor of more direct approach #1307

merged 1 commit into from Jan 27, 2023

Conversation

art-alexeyenko
Copy link
Contributor

  • Changes jss-component-factory in base Angular package to use loadChildren promise directly, removing obsolete logic.

Testing Details

Manual testing in connected mode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 26, 2023 23:58
illiakovalenko
illiakovalenko approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@illiakovalenko illiakovalenko merged commit 238038f into dev Jan 27, 2023
@illiakovalenko illiakovalenko deleted the bug/angular-lazyload branch January 27, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@art-alexeyenko @illiakovalenko