Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG with updated version strategy #1330

Merged
merged 5 commits into from Feb 7, 2023

Conversation

sc-addypathania
Copy link
Contributor

@sc-addypathania sc-addypathania commented Feb 7, 2023

Update changelog with semantic version strategy details.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-addypathania sc-addypathania requested a review from a team February 7, 2023 01:34
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, review few suggestions below 👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@illiakovalenko
Copy link
Contributor

@sc-addypathania Also I would add some description above the details you provided, to give some context

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some suggestions :)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@ambrauer ambrauer merged commit 2aa4c11 into dev Feb 7, 2023
@ambrauer ambrauer deleted the feature/563226-update-changelog branch February 7, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants