Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Fix angular app build failure #1448

Merged
merged 2 commits into from Apr 25, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Apr 24, 2023

Description / Motivation

This is a workaround for webpack/webpack#16981
build-angular would automatically load webpack version 5.80 (or later), however it causes angular app build to fail.
This does not happen with older node and npm versions (16, 6.x respectively) for some reason, but does reproduce with nodejs 18.x.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - test inside and outside of monorepo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team April 24, 2023 20:39
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko changed the title [angular] Fix angular app build failure [Angular] Fix angular app build failure Apr 25, 2023
@illiakovalenko illiakovalenko merged commit 9f9d746 into dev Apr 25, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the bug/582011-angular-build-error branch April 25, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants