[sitecore-jss-react][templates/nextjs] Add support for client BYOC imports and import new SitecoreForm component #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
reviewed
Oct 9, 2023
...-sitecore-jss/src/templates/nextjs-sxa/scripts/scaffold-component/plugins/next-steps-byoc.ts
Outdated
Show resolved
Hide resolved
...-sitecore-jss/src/templates/nextjs-sxa/scripts/scaffold-component/plugins/next-steps-byoc.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/Layout.tsx
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/byoc-imports/index.client.ts
Show resolved
Hide resolved
ambrauer
reviewed
Oct 10, 2023
Inviz
reviewed
Oct 11, 2023
packages/create-sitecore-jss/src/templates/nextjs/src/byoc-imports/index.client.ts
Show resolved
Hide resolved
Inviz
reviewed
Oct 11, 2023
|
Added some comments. Looking good so far! thanks a lot guys! |
…s-528-integrate-forms-client-byoc # Conflicts: # packages/create-sitecore-jss/src/templates/nextjs/package.json # packages/sitecore-jss-react/package.json # yarn.lock
art-alexeyenko
deleted the
feature/jss-528-integrate-forms-client-byoc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
BYOC components need to be imported into app's Layout in order to be available for use. Initial introduction of BYOC in JSS enabled component auto-import through component-builder.
Moving forward, we want to allow a more controlled approach to BYOC registration and import. This PR adds two points for this:
This PR also adds a deafult import for new SitecoreForm BYOC component using this approach.
Testing Details
Types of changes