Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NextJs] [EE] Use relative URLs for internal editing API calls #544

Merged
merged 1 commit into from Feb 1, 2021

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Feb 1, 2021

Use relative URLs for internal editing API requests instead of PUBLIC_URL which isn't always resolvable within containerized environments.

Description

Motivation

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

@ambrauer ambrauer merged commit 2cbfe8c into dev Feb 1, 2021
@ambrauer ambrauer deleted the feature/459538 branch February 1, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants