Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #112: Implement ARIA role mappings for SVG #129

Merged
merged 9 commits into from
Jun 27, 2019

Conversation

Bugvi-Benjamin-M
Copy link
Contributor

This is the first version. There are some issues that need to be handled at a later stage.

packages/alfa-aria/src/features/svg/audio.ts Outdated Show resolved Hide resolved
packages/alfa-aria/src/features/svg/symbol.ts Outdated Show resolved Hide resolved
niclashedam
niclashedam previously approved these changes Jun 25, 2019
Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kasperisager kasperisager added this to In progress in ⚙️ Development via automation Jun 27, 2019
@kasperisager kasperisager changed the title Svg-Aria Mappings Closes #112: Implement ARIA role mappings for SVG Jun 27, 2019
@kasperisager kasperisager merged commit d34800d into master Jun 27, 2019
⚙️ Development automation moved this from In progress to Done Jun 27, 2019
@kasperisager kasperisager deleted the svg-aria-mappings branch June 27, 2019 12:49
kasperisager added a commit that referenced this pull request Aug 9, 2019
* 'master' of https://github.com/Siteimprove/alfa:
  Correctly account for whitespace
  Include declaration diagnostics
  Improve Jasmine error messages
  Add test case for `<template>` tag
  Adjust argument name
  Adjust some ARIA roles
  No need for a `WeakMap`
  Add missing files to TypeScript configs
  Lint files
  Move some doc files around
  Update dependencies
  Closes #57: Adding support for AnB Microsyntax (#131)
  README updates
  Update README.md
  Closes #78: Generate TODO.md from @todo (and similar) comments (#125)
  Closes #132: Added a few tests regarding the svg aria mappings (#133)
  Closes #112: Implement ARIA role mappings for SVG (#129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
⚙️ Development
  
🏁 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants