fix a small bug of enqueueUpdate

Siubaak · Apr 12, 2019 · 1598b63 · 1598b63
1 parent 5a34b8b
commit 1598b63
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/hooks/effect.ts b/src/hooks/effect.ts
@@ -15,7 +15,7 @@ export default function useEffect(effect: Effect, guard: any[] = null) {
       const prevGuard = instance.prevGuard
 
       if (is.undefined(prevGuard)) {
-        throw new Error('unmatch any effects. please don\'t call useEffect in if/loop statement')
+        throw new Error('unmatch any effects, please don\'t call useEffect in if/loop statement')
       }
 
       let shouldCall = false

diff --git a/src/instances/dom.ts b/src/instances/dom.ts
@@ -79,9 +79,7 @@ export default class DOMInstance implements Instance {
     }
 
     emitter.on('loaded', () => {
-      if (this.node) {
-        this.node.removeAttribute(DATA_ID)
-      }
+      if (this.node) this.node.removeAttribute(DATA_ID)
     })
 
     return markup

diff --git a/src/instances/text.ts b/src/instances/text.ts
@@ -27,9 +27,7 @@ export default class TextInstance implements Instance {
       const wrapper = getNode(this.id)
       if (wrapper) {
         this.node = wrapper.firstChild as Text
-        if (!this.node) {
-          this.node = createNode('') as Text
-        }
+        if (!this.node) this.node = createNode('') as Text
         wrapper.parentNode.insertBefore(this.node, wrapper)
         wrapper.remove()
       }

diff --git a/src/renderer/reconciler.ts b/src/renderer/reconciler.ts
@@ -57,7 +57,9 @@ class Reconciler {
   }
 
   enqueueUpdate(instance: Instance, element: Elem): void {
-    this.dirtyList.current.push({ instance, element })
+    if (this.dirtyList.current) {
+      this.dirtyList.current.push({ instance, element })
+    }
   }
 
   private runBatchUpdate() {