Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix engine modifying AST #61

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix engine modifying AST #61

merged 1 commit into from
May 6, 2020

Conversation

Llorx
Copy link
Contributor

@Llorx Llorx commented May 6, 2020

Template literals AST were being modified, so they only worked the first time they ran.

@Llorx
Fix engine modifying AST
614a59c 
Template literals AST were being modified, so they only worked the first time they ran.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 273

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.432%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/evaluate/expression.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 1028
Relevant Lines: 1344
💛 - Coveralls

@Siubaak Siubaak merged commit 9848a88 into Siubaak:master May 6, 2020
@Llorx Llorx deleted the patch-2 branch May 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Llorx @coveralls @Siubaak