Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawTextProcessor - Handle Empty Paths #152

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

I discovered this issue while testing the Fonts library. The fix was simple enough but I added some additional refactoring of the test font loading in the test code to make future testing easier.

@JimBobSquarePants JimBobSquarePants added bug Something isn't working text labels Jul 15, 2021
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc.1 milestone Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #152 (81385ac) into master (0849d85) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   69.85%   69.86%   +0.01%     
==========================================
  Files          90       90              
  Lines        5139     5141       +2     
  Branches     1048     1049       +1     
==========================================
+ Hits         3590     3592       +2     
  Misses       1338     1338              
  Partials      211      211              
Flag Coverage 螖
unittests 69.86% <100.00%> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ssing/Processors/Text/DrawTextProcessor{TPixel}.cs 97.18% <100.00%> (+0.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0849d85...81385ac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants