Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaults documentation of ShapeOptions and TextOptions properties #156

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Aug 1, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Some defaults value documentation were wrong. Also, <para/> was added to make the defaults stand out.

Before this pull request:
Screenshot 2021-08-01 at 15 08 34

After this pull request:
Screenshot 2021-08-01 at 15 08 46

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #156 (fb98a82) into master (b58a245) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files          88       88           
  Lines        5135     5135           
  Branches     1048     1048           
=======================================
  Hits         3588     3588           
  Misses       1337     1337           
  Partials      210      210           
Flag Coverage 螖
unittests 69.87% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/ImageSharp.Drawing/Processing/ShapeOptions.cs 100.00% <酶> (酶)
src/ImageSharp.Drawing/Processing/TextOptions.cs 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b58a245...fb98a82. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants