Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Svg Path #217

Merged
merged 7 commits into from
Apr 15, 2022
Merged

Parse Svg Path #217

merged 7 commits into from
Apr 15, 2022

Conversation

tocsoft
Copy link
Member

@tocsoft tocsoft commented Apr 13, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adds Path.TryParseSvgPath
This API converts a path in the SVG path syntax into an IPath instance.

@tocsoft
Copy link
Member Author

tocsoft commented Apr 13, 2022

This still has an issue currently in the handling of a T command (failing to calculate the correct additional point.) now working

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #217 (bc53f7d) into main (f3f1edf) will increase coverage by 0%.
The diff coverage is 77%.

@@         Coverage Diff          @@
##           main   #217    +/-   ##
====================================
  Coverage    71%    71%            
====================================
  Files        87     87            
  Lines      5176   5307   +131     
  Branches   1069   1089    +20     
====================================
+ Hits       3694   3797   +103     
- Misses     1273   1297    +24     
- Partials    209    213     +4     
Flag Coverage Δ
unittests 71% <77%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp.Drawing/Shapes/Path.cs 77% <76%> (-2%) ⬇️
src/ImageSharp.Drawing/Shapes/PathBuilder.cs 89% <100%> (+<1%) ⬆️
src/ImageSharp.Drawing/Shapes/ArcLineSegment.cs 96% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f1edf...bc53f7d. Read the comment docs.

@tocsoft tocsoft marked this pull request as ready for review April 14, 2022 11:43
@JimBobSquarePants
Copy link
Member

StandingOvationGIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants