Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply upstream clipper fix 500 #272

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Applies the fix from AngusJohnson/Clipper2@d18faa9 to our port.

@JimBobSquarePants JimBobSquarePants added bug Something isn't working upstream-issue labels May 5, 2023
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #272 (52b7d2e) into main (7677cfa) will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #272   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        97     97           
  Lines      5067   5067           
  Branches    932    932           
===================================
  Hits       3985   3985           
  Misses      898    898           
  Partials    184    184           
Flag Coverage 螖
unittests 78% <100%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...rp.Drawing/Shapes/PolygonClipper/PolygonClipper.cs 64% <100%> (酶)

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit 626900c into main May 5, 2023
9 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/upstream-clipper-fix branch August 15, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream-issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants