Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Fonts and implement upstream clipper fix #278

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

  • Updates Fonts to 1.0.0-beta19.15
  • Applies an upstream fix from Clipper2 that further reduced extraneous vertices in solutions.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #278 (3ba5a75) into main (7b19f39) will decrease coverage by 1%.
The diff coverage is 68%.

@@         Coverage Diff         @@
##           main   #278   +/-   ##
===================================
- Coverage    79%    79%   -1%     
===================================
  Files        97     97           
  Lines      5088   5093    +5     
  Branches    945    947    +2     
===================================
+ Hits       4025   4026    +1     
+ Misses      875    868    -7     
- Partials    188    199   +11     
Flag Coverage 螖
unittests 79% <68%> (-1%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...arp.Drawing/Shapes/PolygonClipper/ClipperOffset.cs 100% <酶> (酶)
...rp.Drawing/Shapes/PolygonClipper/PolygonClipper.cs 64% <0%> (+<1%) 猬嗭笍
...ImageSharp.Drawing/Shapes/Text/BaseGlyphBuilder.cs 87% <0%> (-2%) 猬囷笍
....Drawing/Shapes/PolygonClipper/PolygonOffsetter.cs 73% <72%> (-3%) 猬囷笍
...rocessing/Processors/Text/RichTextGlyphRenderer.cs 95% <100%> (酶)

... and 1 file with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants
Copy link
Member Author

Stupid NET 472 x86!!

tocsoft
tocsoft previously approved these changes Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants