Add Convenience Constructors to shapes #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra and
brianpopow
tocsoft
reviewed
Aug 14, 2023
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="Path"/> class. | ||
| /// </summary> | ||
| /// <param name="points">The collection of points.</param> |
There was a problem hiding this comment.
worth pointing out these are processed as a series of linear line segments
| @@ -11,6 +11,15 @@ namespace SixLabors.ImageSharp.Drawing | |||
| /// </summary> | |||
| public class Polygon : Path | |||
| { | |||
| /// <summary> | |||
| /// Initializes a new instance of the <see cref="Polygon"/> class. | |||
There was a problem hiding this comment.
again woth pointing out thye are handled as a LinearLineSegment
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
===================================
Coverage 80% 80%
===================================
Files 97 97
Lines 5020 5024 +4
Branches 919 919
===================================
+ Hits 4025 4029 +4
Misses 796 796
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more.
馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
tocsoft
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #100