Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build and repo config to match ImageSharp #102

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

  • Use MinVer for build numbers.
  • Add SourceLink and deterministic builds
  • Update ImageSharp
  • Add new sponsorship details.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #102 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   77.63%   77.08%   -0.55%     
==========================================
  Files          46       46              
  Lines        1292     1292              
  Branches      224      207      -17     
==========================================
- Hits         1003      996       -7     
- Misses        222      234      +12     
+ Partials       67       62       -5     
Flag Coverage 螖
#unittests 77.08% <酶> (-0.55%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...harp.Web/Middleware/ImageSharpMiddlewareOptions.cs 56.00% <0.00%> (-12.00%) 猬囷笍
...eSharp.Web/Providers/PhysicalFileSystemProvider.cs 80.00% <0.00%> (-5.00%) 猬囷笍
src/ImageSharp.Web/ChunkedMemoryStream.cs 73.55% <0.00%> (-1.93%) 猬囷笍
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 73.28% <0.00%> (酶)
src/ImageSharp.Web/ImageCacheMetadata.cs 81.81% <0.00%> (+1.81%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2bce803...11c094c. Read the comment docs.

@JimBobSquarePants JimBobSquarePants requested review from a team, tocsoft, antonfirsov, dlemstra and brianpopow and removed request for a team August 12, 2020 11:53
Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 馃憤

@JimBobSquarePants JimBobSquarePants merged commit 6213ec3 into master Aug 12, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/deps-sponsors branch August 12, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants