Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Code Quality Fixes #105

Merged
merged 9 commits into from
Aug 22, 2020
Merged

Various Code Quality Fixes #105

merged 9 commits into from
Aug 22, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

I gave the library a bit of a read through to get things ready for a V1.

  • Fixes solution so tests and benchmarks run again.
  • Fix UTC datetime bug in cache check.
  • Remove unnecessary stream copy.
  • Reduce allocations for string generation when caching.
  • Use async stream dispose.

@JimBobSquarePants
Copy link
Member Author

Thanks @tocsoft

I just need to fix up the integration tests to handle the build output location then I鈥檒l merge it.

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #105 into master will increase coverage by 0.10%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   77.08%   77.19%   +0.10%     
==========================================
  Files          46       46              
  Lines        1292     1324      +32     
  Branches      207      211       +4     
==========================================
+ Hits          996     1022      +26     
- Misses        234      238       +4     
- Partials       62       64       +2     
Flag Coverage 螖
#unittests 77.19% <83.33%> (+0.10%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...s.Azure/Resolvers/AzureBlobStorageImageResolver.cs 90.00% <酶> (酶)
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 72.48% <50.00%> (-0.81%) 猬囷笍
src/ImageSharp.Web/Caching/CacheHash.cs 76.47% <60.00%> (-15.84%) 猬囷笍
.../ImageSharp.Web/Caching/PhysicalFileSystemCache.cs 94.28% <95.83%> (+0.40%) 猬嗭笍
src/ImageSharp.Web/Caching/HexEncoder.cs 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cd70936...f7422f3. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit a11d088 into master Aug 22, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/code-quality branch August 22, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants