Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality #109

Merged
merged 8 commits into from
Aug 26, 2020
Merged

Code Quality #109

merged 8 commits into from
Aug 26, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

General pass to improve quality and coverage before I make potentially more substantial changes.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #109 into master will increase coverage by 4.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   78.01%   82.03%   +4.02%     
==========================================
  Files          45       44       -1     
  Lines        1128     1091      -37     
  Branches      174      160      -14     
==========================================
+ Hits          880      895      +15     
+ Misses        191      145      -46     
+ Partials       57       51       -6     
Flag Coverage 螖
#unittests 82.03% <94.11%> (+4.02%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/ImageSharp.Web/Commands/CommandParser.cs 98.27% <0.00%> (+1.66%) 猬嗭笍
...ageSharp.Web/Commands/Converters/ColorConverter.cs 88.46% <酶> (+13.46%) 猬嗭笍
src/ImageSharp.Web/Commands/CommandDescriptor.cs 88.88% <100.00%> (+18.88%) 猬嗭笍
...Sharp.Web/Commands/Converters/ArrayConverter{T}.cs 100.00% <100.00%> (+33.33%) 猬嗭笍
...Web/Commands/Converters/IntegralNumberConverter.cs 100.00% <100.00%> (酶)
src/ImageSharp.Web/FormattedImage.cs 84.61% <100.00%> (酶)
...ageSharp.Web/Processors/WebProcessingExtensions.cs 100.00% <100.00%> (+40.00%) 猬嗭笍
...rc/ImageSharp.Web/Processors/ResizeWebProcessor.cs 68.33% <0.00%> (+5.00%) 猬嗭笍
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c870521...a171613. Read the comment docs.

@@ -21,7 +21,7 @@ public sealed class FormattedImage : IDisposable
/// </summary>
/// <param name="image">The image.</param>
/// <param name="format">The format.</param>
public FormattedImage(Image<Rgba32> image, IImageFormat format)
internal FormattedImage(Image<Rgba32> image, IImageFormat format)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaking. We should never have exposed it.

@JimBobSquarePants JimBobSquarePants changed the title WIP Code Quality Code Quality Aug 25, 2020
@JimBobSquarePants JimBobSquarePants requested a review from a team August 25, 2020 21:31
@JimBobSquarePants JimBobSquarePants marked this pull request as ready for review August 25, 2020 21:31
@JimBobSquarePants JimBobSquarePants merged commit fc1721b into master Aug 26, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/code-quality branch August 26, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants