Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify middleware workflow. #110

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Simplify middleware workflow. #110

merged 4 commits into from
Aug 28, 2020

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Aug 27, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Simplifies the middleware workflow and removes the requirement for stream copying in individual providers.
Adds tests to ensure we handle cached and non-cached scenarios.

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #110 into master will increase coverage by 0.86%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   82.03%   82.89%   +0.86%     
==========================================
  Files          44       44              
  Lines        1091     1076      -15     
  Branches      160      158       -2     
==========================================
- Hits          895      892       -3     
+ Misses        145      136       -9     
+ Partials       51       48       -3     
Flag Coverage Δ
#unittests 82.89% <84.61%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ndencyInjection/ImageSharpCoreBuilderExtensions.cs 75.86% <ø> (-2.27%) ⬇️
...DependencyInjection/ServiceCollectionExtensions.cs 86.36% <ø> (-0.60%) ⬇️
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 78.00% <83.60%> (+6.57%) ⬆️
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 77.27% <100.00%> (-1.46%) ⬇️
...s.Azure/Resolvers/AzureBlobStorageImageResolver.cs 100.00% <100.00%> (+7.69%) ⬆️
...eSharp.Web/Providers/PhysicalFileSystemProvider.cs 85.00% <0.00%> (+5.00%) ⬆️
...arp.Web/Caching/PhysicalFileSystemCacheResolver.cs 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1721b...6e330b8. Read the comment docs.

@JimBobSquarePants JimBobSquarePants requested a review from a team August 27, 2020 16:13
@JimBobSquarePants
Copy link
Member Author

I'm gonna go rogue here and merge this. I've got limited availability to work on the library so want to press on while I can.

@JimBobSquarePants JimBobSquarePants merged commit eec9fe8 into master Aug 28, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/code-quality-2 branch August 28, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant