-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cache Config To Use TimeSpan #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 82.89% 82.67% -0.23%
==========================================
Files 44 44
Lines 1076 1068 -8
Branches 158 157 -1
==========================================
- Hits 892 883 -9
- Misses 136 137 +1
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think I would just make more sense to just have a single option called MaxCacheTimeout
and it be of type TimeSpan
instead of the now 3 separate parts it then allows for super fine grained adjustments without have to keep adding additional properties and having to then coherence the multiple fields into a TimeSpan
anyway.
Yeah, we'd have to determine a format though that can be parsed invariantly. |
|
https://docs.microsoft.com/en-us/dotnet/standard/base-types/standard-timespan-format-strings The invariant format looks like this |
Beautiful. I'll make the changes. |
@@ -74,7 +74,7 @@ jobs: | |||
XUNIT_PATH: .\tests\ImageSharp.Web.Tests # Required for xunit | |||
|
|||
- name: Update Codecov | |||
uses: codecov/codecov-action@v1.0.7 | |||
uses: codecov/codecov-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to do this in all our repos. They've changed things which causes a 400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better 馃憤
Prerequisites
Description
Updates configuration to allow caching by any
TimeSpan
configuration. See #104This is a necessary breaking change.
I've also reintroduced the samples webapp into the solution.