Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Dependency Injection #115

Merged
merged 6 commits into from
Sep 2, 2020
Merged

Simplify Dependency Injection #115

merged 6 commits into from
Sep 2, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

  • Removes the AddImageSharpCore extensions. We don't need them anymore and they're confusing.
  • Removes weird registration of services via options sub properties.
  • Adds ClearProviders and ClearProcessors to allow simplified reset of registered services.
  • Use ArrayPool for supplying buffers for hashing long strings.
  • Fix missing .Web suffix from readme.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #115 into master will increase coverage by 0.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   84.01%   84.03%   +0.01%     
==========================================
  Files          47       47              
  Lines        1126     1121       -5     
  Branches      161      162       +1     
==========================================
- Hits          946      942       -4     
  Misses        128      128              
+ Partials       52       51       -1     
Flag Coverage 螖
#unittests 84.03% <94.11%> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...DependencyInjection/ServiceCollectionExtensions.cs 94.11% <80.00%> (-1.34%) 猬囷笍
src/ImageSharp.Web/Caching/CacheHash.cs 100.00% <100.00%> (+23.52%) 猬嗭笍
...DependencyInjection/ImageSharpBuilderExtensions.cs 69.64% <100.00%> (酶)
src/ImageSharp.Web/FormatUtilities.cs 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1695866...54a57f3. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 22352d1 into master Sep 2, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/simplify-di branch September 2, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants