Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with NET 5 SDK InternalsVisibleTo #116

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

.NET 5 bring a native InternalVisibleTo target implementation that is incompatible with our current implementation. The fix is simple, update our property to use the same Key attribute rather than PublicKey.

Tested using Visual Studio 16.8.0 Preview 2.1 and .NET 5 SDK 5.0.100-preview.8.20417.9

cc/ @sandcastle

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   84.64%   84.64%           
=======================================
  Files          46       46           
  Lines        1146     1146           
  Branches      159      159           
=======================================
  Hits          970      970           
  Misses        128      128           
  Partials       48       48           
Flag Coverage 螖
#unittests 84.64% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...DependencyInjection/ImageSharpBuilderExtensions.cs 69.64% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8e7f89b...8170533. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit b4b3fd5 into master Sep 3, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-net5-build branch September 3, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant