Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to enable setting a different CacheRoot #127

Merged
merged 6 commits into from
Nov 12, 2020

Conversation

stefannikolei
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Adding a new Option for the cache implementation. Now the CacheRoot can be set to an different folder than the webroot

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #127 (af70a40) into master (2c5961e) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   88.61%   88.76%   +0.14%     
==========================================
  Files          43       43              
  Lines        1221     1228       +7     
  Branches      144      146       +2     
==========================================
+ Hits         1082     1090       +8     
+ Misses        100       99       -1     
  Partials       39       39              
Flag Coverage 螖
unittests 88.76% <100.00%> (+0.14%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
.../ImageSharp.Web/Caching/PhysicalFileSystemCache.cs 97.05% <100.00%> (+0.28%) 猬嗭笍
...harp.Web/Caching/PhysicalFileSystemCacheOptions.cs 100.00% <100.00%> (+100.00%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2c5961e...af70a40. Read the comment docs.

introduce ifdef for the different plattforms to test the path on all 3 operating systems
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you drop the in modifiers, this looks great. Thanks!

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thanks!

I'm planning an official release in a few days but you will be able to grab the build from MyGet in the interim once merged.

@JimBobSquarePants JimBobSquarePants merged commit afff0fe into SixLabors:master Nov 12, 2020
@stefannikolei stefannikolei deleted the feature/cacheRoot branch November 12, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants